[
https://issues.apache.org/jira/browse/SSHD-1261?focusedWorklogId=770243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770243
]
ASF GitHub Bot logged work on SSHD-1261:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/22 15:43
Start Date: 13/May/22 15:43
Worklog Time Spent: 10m
Work Description: lgoldstein closed pull request #218: [SSHD-1261] Fixed
possible pending unfinished pending write request if ChannelAsyncOutputStream
closed prematurely
URL: https://github.com/apache/mina-sshd/pull/218
Issue Time Tracking
-------------------
Worklog Id: (was: 770243)
Time Spent: 50m (was: 40m)
> Sometimes async write listener is not called
> --------------------------------------------
>
> Key: SSHD-1261
> URL: https://issues.apache.org/jira/browse/SSHD-1261
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Evgeny Pasynkov
> Assignee: Lyor Goldstein
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Hello,
> I have discovered the case when the async write listener is not called.
> Imagine the case: The `ChannelAsyncOutputStream::doWriteIfPossible` method
> discover that window size is too small (lines 160-167). It setup new future
> and exit the doWriteIfPossible method, relying on `onWindowExpanded` will be
> called shortly. But if the channel is disconnected, the method will never be
> invoked, thus future won't be completed.
> I suggest adding the following override to ChannelAsyncOutputStream class:
> {code:java}
> @Override
> protected void doCloseImmediately() {
> abortCurrentWrite();
> super.doCloseImmediately();
> }
> protected synchronized void abortCurrentWrite() {
> IoWriteFutureImpl future = pendingWrite.get();
> if (future != null) {
> future.setValue(new ClosedChannelException());
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
