tomaswolf commented on PR #227: URL: https://github.com/apache/mina-sshd/pull/227#issuecomment-1156165890
All right. The MINA problems are resolved now. It looks as if this shutdownOutputStream() stuff was never tested with MINA at all; when SSHD-902 was done, the core tests didn't even run in the CI build with MINA. It now turns out that MINA doesn't like it at all when we fiddle around with the socket directly. My solution for MINA is to just close the session once all pending writes have been written. That's doable via standard MINA API (IoSession.closeOnFlush()), doesn't confuse the MINA select loop, doesn't cause slow-down as observed in the previous versions of this PR, and makes the new Sshd1055Test pass without causing problems for the other tests. Note that the new Sshd1055Test is disabled in the maven build because it uses testcontainers, and setting up testcontainers doesn't work well with the re-useable test JAR due to classpath problems (test resources are not found). I have run that new test manually with MINA and Netty, and it passes. With Nio2, it is run in the CI build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
