tomaswolf commented on code in PR #237: URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938932950
########## sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sshd.common.config; + +import java.util.Objects; + +import org.apache.sshd.common.util.ValidateUtils; + +/** + * @author <a href="mailto:[email protected]";>Apache MINA SSHD Project</a> + */ +public final class PreferredAuthConfigEntry { + private final String configKeyName; + private final String authFactoryName; + private final boolean enabledByDefault; + private final int hashValue; + private final String strValue; + + public PreferredAuthConfigEntry( + String configKeyName, String authFactoryName, boolean enabledByDefault) { + this.configKeyName = ValidateUtils.checkNotNullAndNotEmpty(configKeyName, "No configuration key name provided"); + this.authFactoryName + = ValidateUtils.checkNotNullAndNotEmpty(authFactoryName, "No authentication factory name provided"); + this.enabledByDefault = enabledByDefault; + this.hashValue = Objects.hash(configKeyName, authFactoryName, enabledByDefault); + this.strValue Review Comment: It wastes space, even if toString() is never called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
