[
https://issues.apache.org/jira/browse/SSHD-1293?focusedWorklogId=805367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805367
]
ASF GitHub Bot logged work on SSHD-1293:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 21:03
Start Date: 31/Aug/22 21:03
Worklog Time Spent: 10m
Work Description: knalli commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1233418548
Note: The existing test `testLocalForwardingNative` isn't covering this
(anymore) because the semaphore `tearDownSignal` is checked in the events (like
`tornDownExplicitTunnel`) only
Issue Time Tracking
-------------------
Worklog Id: (was: 805367)
Time Spent: 20m (was: 10m)
> ExplicitPortForwardingTracker does not unbind auto-allocated one
> ----------------------------------------------------------------
>
> Key: SSHD-1293
> URL: https://issues.apache.org/jira/browse/SSHD-1293
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Jan Philipp
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have noticed that the de-allocation (unbind of a forwarding) initiated by
> {{org.apache.sshd.client.session.forward.ExplicitPortForwardingTracker}} in
> the {{close()}} method will not no close the actual forwarding. Said that,
> this leaves the connection and a file handler open.
> The actual main reason is that it uses
> \{{manager.stopLocalPortForwarding(this.getLocalAddress());}} which means it
> stops the tunnel identified the "local address" which is the same as provided
> by the user. If the user is using a local address with port {{0}} (which
> seems legit since the docs state this explicitly), the local address will be
> still something like {{0.0.0.0:0}} or maybe {{{}127.0.0.1:0{}}}, but only the
> "bound address" contains the actual dynamic auto-allocated port.
> If the user uses an explicit port, this would work.
> As a workaround, I have added after {{tracker.close()}} an explicit
> {{session.stopLocalPortForwarding(tracker.getBoundAddress())}}. I don't know
> if this would your final solution or this would be an issue in
> \{{DefaultForwarder#stopLocalPortForwarding}}.
>
> I'm using 2.8 right now; as far as I can see there are no changes in 2.9
> regarding this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]