tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967176879
##########
sshd-common/src/main/java/org/apache/sshd/common/future/DefaultSshFuture.java:
##########
@@ -227,6 +252,16 @@ public void cancel() {
setValue(CANCELED);
}
+ public boolean isTimeout() {
+ synchronized (lock){
Review Comment:
Nit: missing blank before {
##########
sshd-common/src/main/java/org/apache/sshd/common/future/DefaultSshFuture.java:
##########
@@ -227,6 +252,16 @@ public void cancel() {
setValue(CANCELED);
}
+ public boolean isTimeout() {
+ synchronized (lock){
+ return timeout;
+ }
+ }
+
+ private void setTimeout(){
Review Comment:
Nit: missing blank before {
##########
sshd-common/src/main/java/org/apache/sshd/common/future/DefaultSshFuture.java:
##########
@@ -227,6 +252,16 @@ public void cancel() {
setValue(CANCELED);
}
+ public boolean isTimeout() {
Review Comment:
Missing javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
