tomaswolf commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1277771882
> keep the existing verify without the flag and delegate it to call the new verify using some default that you deem relevant Yes, that was my thought exactly. The new default for the existing `verify()` would be to cancel to avoid this problem of having a "hidden" session established after the time-out that the user cannot really get to. That would solve the reported problems; and I consider calling verify() on the same `ConnectFuture` in different threads so extremely borderline (unfortunately it's something that the current API has always allowed) that it is IMO acceptable to require client code that does that currently to be changed. A notice to that effect in the release notes will be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
