tomaswolf commented on issue #268: URL: https://github.com/apache/mina-sshd/issues/268#issuecomment-1311312110
> proposing to roll back Yes. > and generally refuse to wait for a response to a heartbeat? No. Seems to me that rolling back would use the synchronous `session.request()` method (again), which does wait for the response and which does throw a `SocketTimeoutException` if a timeout occurs. If that is correct, then rolling back would be the preferred solution since it simplifies the code quite a bit. > Are there any disadvantages or fundamental errors in the solution proposed by @robober? No. But looking back at this code, I don't see anymore why I even changed it. Using the asynchronous global request but then waiting on the latch is still blocking of course. But heartbeats are sent from separate threads anyway, so this doesn't block an I/O thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
