tomaswolf commented on code in PR #314:
URL: https://github.com/apache/mina-sshd/pull/314#discussion_r1081679988


##########
sshd-sftp/src/main/java/org/apache/sshd/sftp/server/AbstractSftpSubsystemHelper.java:
##########
@@ -338,6 +338,9 @@ protected void process(Buffer buffer) throws IOException {
             if (type == SftpConstants.SSH_FXP_INIT) {
                 throw e;
             }
+            if (log.isDebugEnabled()) {
+                log.debug("process({}) Exception", session, e);
+            }

Review Comment:
   Why don't you do this _inside_ `sendStatus(Buffer buffer, int id, Throwable 
e, int cmd, Object... args)`? There would be only a single place to change. The 
exception stack trace that would be logged would identify where it occurred.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to