tomaswolf commented on code in PR #315:
URL: https://github.com/apache/mina-sshd/pull/315#discussion_r1089945935
##########
sshd-common/src/main/java/org/apache/sshd/common/future/DefaultSshFuture.java:
##########
@@ -98,18 +145,19 @@ public boolean isDone() {
*
* @param newValue The operation result
*/
Review Comment:
Actually, returning the value set is a left-over from an early attempt. It's
used in one place only, and that can be rewritten to not need it.
Changed back to `void`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
