beijishiqidu opened a new issue, #371:
URL: https://github.com/apache/mina-sshd/issues/371
### Description
I wrote a simple demo
The Server code：
```java
public static void main(String[] args) throws Exception {
SshServer sshd = SshServer.setUpDefaultServer();
KeyPairProvider keyPair = new SimpleGeneratorHostKeyProvider();
sshd.setKeyPairProvider(keyPair);
sshd.setPort(9999);
List<SubsystemFactory> namedFactoryList = new ArrayList<>();
namedFactoryList.add(new SftpSubsystemFactory());
sshd.setSubsystemFactories(namedFactoryList);
sshd.setFileSystemFactory(new VirtualFileSystemFactory() {
@Override
public Path getUserHomeDir(SessionContext session) {
return Paths.get("D:\\sshdhomepath");
}
});
sshd.setPasswordAuthenticator(new MyPasswordAuthenticator());
sshd.start();
while (true) {
Thread.sleep(60000);
}
}
private static class MyPasswordAuthenticator implements
PasswordAuthenticator {
public boolean authenticate(String username, String password,
ServerSession session)
throws PasswordChangeRequiredException, AsyncAuthException {
log.info("current session is = {}", session);
return "sftp".equals(username) && "sftp".equals(password);
}
}
```
The Client code:
```java
public static void main(String[] args) throws Exception {
SshClient client = SshClient.setUpDefaultClient();
client.start();
try (ClientSession session = client.connect("sftp", "127.0.0.1",
9999).verify().getSession()) {
session.addPasswordIdentity("sftp");
if (session.auth().verify().isSuccess()) {
for (int i = 0; i < 1000; i++) {
SftpClientFactory factory = new
DefaultSftpClientFactory();
SftpClient sftpClient =
factory.createSftpClient(session);
try (FileInputStream in = new
FileInputStream("D:\\20230113\\202301131049.dump")) {
SftpClient.CloseableHandle handle =
sftpClient.open("202301131049.dump" + i,
SftpClient.OpenMode.Write,
SftpClient.OpenMode.Create);
int buff_size = 1024 * 1024;
byte[] src = new byte[buff_size];
int len;
long fileOffset = 0L;
while ((len = in.read(src)) != -1) {
sftpClient.write(handle, fileOffset, src, 0,
len);
fileOffset += len;
}
} catch (Exception e) {
e.printStackTrace();
}
}
log.info("upload file success");
} else {
log.error("can not create session");
}
Thread.sleep(2000);
}
client.close();
}
```
### Motivation
I refer to hackers or other clients and deliberately do not close the
connection.
The following code is used to run the sshd client，I didn't turn it off, and
I tried 1,000 times.
```java
SftpClient sftpClient = factory.createSftpClient(session);
```
So, When I went to trace the stack on the server side, I found that many of
the SftpSubsystem objects were not closed.
```shell
sh-4.3$ jstack -l 39322 |grep -i sshd
"sshd-SftpSubsystem-37077-thread-1" #29814 daemon prio=5 os_prio=0
cpu=89.41ms elapsed=2.83s tid=0x00007fcf6400f800 nid=0x1226 waiting on
condition [0x00007fcba4203000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-41846-thread-1" #29795 daemon prio=5 os_prio=0
cpu=2927.78ms elapsed=85.33s tid=0x00007fcf880fa000 nid=0x1137 waiting on
condition [0x00007fcba4d0e000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-33601-thread-1" #29789 daemon prio=5 os_prio=0
cpu=2868.93ms elapsed=167.03s tid=0x00007fcf38190000 nid=0xfea waiting on
condition [0x00007fcba4405000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-8083-thread-1" #29784 daemon prio=5 os_prio=0
cpu=2865.43ms elapsed=248.49s tid=0x00007fcf8801b000 nid=0xe9f waiting on
condition [0x00007fcba3cfe000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-42628-thread-1" #29778 daemon prio=5 os_prio=0
cpu=2872.83ms elapsed=330.10s tid=0x00007fcf40102000 nid=0xdbc waiting on
condition [0x00007fcba4607000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-8096-thread-1" #29773 daemon prio=5 os_prio=0
cpu=2937.80ms elapsed=412.09s tid=0x00007fcf300ca800 nid=0xc70 waiting on
condition [0x00007fcba4809000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-44074-thread-1" #29768 daemon prio=5 os_prio=0
cpu=2847.39ms elapsed=494.56s tid=0x00007fcf38191800 nid=0xb25 waiting on
condition [0x00007fce619e0000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-27927-thread-1" #29763 daemon prio=5 os_prio=0
cpu=2970.71ms elapsed=576.55s tid=0x00007fcf3001a800 nid=0x9da waiting on
condition [0x00007fcba4102000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-7402-thread-1" #29739 daemon prio=5 os_prio=0
cpu=2908.31ms elapsed=658.80s tid=0x00007fcf6800d000 nid=0x8b1 waiting on
condition [0x00007fcba4708000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-26637-thread-1" #29733 daemon prio=5 os_prio=0
cpu=2869.69ms elapsed=740.26s tid=0x00007fcf5c0e3000 nid=0x765 waiting on
condition [0x00007fcba3bfd000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-43298-thread-1" #29728 daemon prio=5 os_prio=0
cpu=2874.68ms elapsed=822.75s tid=0x00007fcf38011800 nid=0x61a waiting on
condition [0x00007fcba39fb000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-2696-thread-1" #29723 daemon prio=5 os_prio=0
cpu=2875.22ms elapsed=905.24s tid=0x00007fcf6400f000 nid=0x4cd waiting on
condition [0x00007fce61de4000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-9495-thread-1" #29717 daemon prio=5 os_prio=0
cpu=2934.66ms elapsed=987.72s tid=0x00007fcf4000b000 nid=0x3e9 waiting on
condition [0x00007fcba3f00000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-55726-thread-1" #29712 daemon prio=5 os_prio=0
cpu=2847.24ms elapsed=1069.84s tid=0x00007fcf40015800 nid=0x281 waiting on
condition [0x00007fcba3afc000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-46430-thread-1" #29706 daemon prio=5 os_prio=0
cpu=2831.26ms elapsed=1151.76s tid=0x00007fcf64011000 nid=0x134 waiting on
condition [0x00007fcba3dff000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-12464-thread-1" #29686 daemon prio=5 os_prio=0
cpu=2842.01ms elapsed=1233.30s tid=0x00007fcf380de800 nid=0xfeac waiting on
condition [0x00007fcba37f9000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-47609-thread-1" #29679 daemon prio=5 os_prio=0
cpu=2993.85ms elapsed=1314.92s tid=0x00007fcf3c0ce000 nid=0xfdc9 waiting on
condition [0x00007fcba38fa000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-63307-thread-1" #29674 daemon prio=5 os_prio=0
cpu=2592.63ms elapsed=1395.36s tid=0x00007fcf6800b000 nid=0xfc5f waiting on
condition [0x00007fcba36f8000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-10647-thread-1" #29669 daemon prio=5 os_prio=0
cpu=2601.42ms elapsed=1477.21s tid=0x00007fcf88007800 nid=0xfad4 waiting on
condition [0x00007fcba34f6000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-12760-thread-1" #29664 daemon prio=5 os_prio=0
cpu=2558.38ms elapsed=1559.21s tid=0x00007fcf6400e000 nid=0xf9b5 waiting on
condition [0x00007fcba35f7000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SftpSubsystem-23564-thread-1" #29657 daemon prio=5 os_prio=0
cpu=2614.00ms elapsed=1641.23s tid=0x00007fcf7804c800 nid=0xf7e6 waiting on
condition [0x00007fce622e9000]
at
org.apache.sshd.sftp.server.SftpSubsystem.run(SftpSubsystem.java:297)
"sshd-SshServer[146e3c90](port=33233)-nio2-thread-9" #470 daemon prio=5
os_prio=0 cpu=47688.11ms elapsed=298207.55s tid=0x00007fd044013000 nid=0xcad3
waiting on condition [0x00007fcf825ee000]
"sshd-SshServer[146e3c90](port=33233)-nio2-thread-8" #469 daemon prio=5
os_prio=0 cpu=47797.35ms elapsed=298207.56s tid=0x00007fcf4c01c800 nid=0xcad2
waiting on condition [0x00007fcf826ef000]
```
### Alternatives considered
I tried to look for timeout-related configurations in SftpModuleProperties
and CoreModuleProperties, but I didn't find any. So, I'd like to ask, do we
currently support this capability?
Thank you very much
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
