Thanks Emmanuel! Gary
On Tue, Jul 4, 2023, 16:49 Emmanuel Lécharny <elecha...@gmail.com> wrote: > ... and Apache MINA Team page updated! > > On 04/07/2023 22:33, Emmanuel Lécharny wrote: > > Gary has commit rights :-) > > > > That makes me realize that I need to update the Team page. > > > > And, yes, I do think we should thows some meaningful excection. > > > > On 04/07/2023 14:35, Jonathan Valliere wrote: > >> Make a PR > >> > >> On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory <garydgreg...@gmail.com> > >> wrote: > >> > >>> Hi All, > >>> > >>> I noticed that in org.apache.ftpserver.util.EncryptUtils we explicitly > >>> throw RuntimeException. This is usually an anti-pattern as > >>> IllegalArgumentException, IllegalStateException, and others are more > >>> descriptive. > >>> > >>> In the case of EncryptUtils, IllegalArgumentException seems more > >>> appropriate. > >>> > >>> Thoughts? > >>> > >>> Gary > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > >>> For additional commands, e-mail: dev-h...@mina.apache.org > >>> > >>> > >> > > > > -- > *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE > T. +33 (0)4 89 97 36 50 > P. +33 (0)6 08 33 32 61 > emmanuel.lecha...@busit.com https://www.busit.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > >
