lgoldstein commented on code in PR #419:
URL: https://github.com/apache/mina-sshd/pull/419#discussion_r1338980073
##########
sshd-core/src/test/java/org/apache/sshd/util/test/BaseTestSupport.java:
##########
@@ -46,8 +46,8 @@ public abstract class BaseTestSupport extends
JUnitTestSupport {
public static final String TEST_LOCALHOST
= System.getProperty("org.apache.sshd.test.localhost",
SshdSocketAddress.LOCALHOST_IPV4);
- public static final Duration CONNECT_TIMEOUT =
CoreTestSupportUtils.getTimeout("connect", Duration.ofSeconds(7));
- public static final Duration AUTH_TIMEOUT =
CoreTestSupportUtils.getTimeout("auth", Duration.ofSeconds(5));
+ public static final Duration CONNECT_TIMEOUT =
CoreTestSupportUtils.getTimeout("connect", Duration.ofSeconds(10));
+ public static final Duration AUTH_TIMEOUT =
CoreTestSupportUtils.getTimeout("auth", Duration.ofSeconds(8));
Review Comment:
I was worried about possible spurious failures during test execution - you
will also notice that the increase is minor. Furthermore, it should not affect
how long the tests really take since these are **upper bounds** - if the code
completes its flow before this, then it doesn't sit idle by...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
