lgoldstein opened a new pull request, #446: URL: https://github.com/apache/mina-sshd/pull/446
@tomaswolf @gnodet I value your opinion so I would appreciate it if you could take a look at this. I had some doubts as to some pieces of code (don't want to bias your review so I won't say where) so I would really appreciate a fresh set of eyes on this. I apologize for the seemingly large diff on `AbstractSession`, but it is **not** my doing - the Maven formatting plugin we use did this (for whatever reason...). However, I believe it is still quite readable. As far as testing goes, I have tested it with `OpenSSH_8.9p1 Ubuntu-3ubuntu0.5, OpenSSL 3.0.2 15 Mar 2022`. I do plan on adding unit tests for the code, but before I do that I prefer having your feedback, in case more changes are necessary. In this context, I do encourage you to test **both** client and server interoperability with this code as well - perhaps on a different OpenSSH version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
