lgoldstein commented on code in PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#discussion_r1435249686
##########
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java:
##########
@@ -202,13 +213,20 @@ public abstract class AbstractSession extends
SessionHelper {
* Rekeying
*/
protected final AtomicLong inPacketsCount = new AtomicLong(0L);
+ protected final AtomicLong totalIncomingPacketsCount = new AtomicLong(0L);
protected final AtomicLong outPacketsCount = new AtomicLong(0L);
+ protected final AtomicLong totalOutgingPacketsCount = new AtomicLong(0L);
protected final AtomicLong inBytesCount = new AtomicLong(0L);
+ protected final AtomicLong totalIncomingBytesCount = new AtomicLong(0L);
protected final AtomicLong outBytesCount = new AtomicLong(0L);
+ protected final AtomicLong totalOutgoingBytesCount = new AtomicLong(0L);
protected final AtomicLong inBlocksCount = new AtomicLong(0L);
+ protected final AtomicLong totalIncomingBlocksCount = new AtomicLong(0L);
protected final AtomicLong outBlocksCount = new AtomicLong(0L);
+ protected final AtomicLong totalOutgoingBlocksCount = new AtomicLong(0L);
protected final AtomicReference<Instant> lastKeyTimeValue = new
AtomicReference<>(Instant.now());
- // we initialize them here in case super constructor calls some methods
that use these values
+ // we initialize them here in case super constructor calls some methods
that
+ // use these values
Review Comment:
I do not format these comments this way - we have a Maven plugin (that
someone else configured) and this is its result.
##########
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java:
##########
@@ -471,7 +490,8 @@ public MacInformation getMacInformation(boolean incoming) {
public void messageReceived(Readable buffer) throws Exception {
synchronized (decodeLock) {
decoderBuffer.putBuffer(buffer);
- // One of those properties will be set by the constructor and the
other
+ // One of those properties will be set by the constructor and the
+ // other
Review Comment:
I do not format these comments this way - we have a Maven plugin (that
someone else configured) and this is its result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
