tomaswolf commented on issue #532: URL: https://github.com/apache/mina-sshd/issues/532#issuecomment-2237635271
I don't know why the `GitSshdSession` asks for a password up front. It should set appropriate `FilePasswordProvider` and `UserInteraction` implementations based on the JGit `CredentialsProvider` instead (and they should be null-safe). Note that the JGit `CredentialsProvider` is not just for getting credentials. It is a general interface for user interaction similar to `javax.security.auth.callback.CallbackHandler`. In JGit it is used for instance also to prompt the user what to do when an SSH server's host key is not known yet. (If `CredentialsProvider.isInteractive() == true`.) So it might be a good idea anyway to provide a general `CredentialsProvider` implementation. (Though I don't see what this `GitSshdSession` does with it further on -- apparently nothing.) As I mentioned in the JGit issue, another idea might be to use JGit's own binding to Apache MINA sshd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
