tomaswolf commented on issue #577: URL: https://github.com/apache/mina-sshd/issues/577#issuecomment-2302324772
`CoreModuleProperties.ALLOW_DHG1_KEX_FALLBACK` only switches on a fallback. After looking at the code, I think it is dubious, possibly incorrect, and most likely never occurs. The diffie-hellman-group1-sha1 KEX is weak and has been removed from the default list of KEXes. You have to add it explicitly via `ClientBuilder.setKeyExchangeFactories()`. (Or if you're implementing a server, via `ServerBuilder.setKeyExchangeFactories()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
