tomaswolf commented on issue #590: URL: https://github.com/apache/mina-sshd/issues/590#issuecomment-2323421799
Seems I misunderstood the problem. I now looked closer at bc-fips, and it is indeed a different beast than normal BC. So the idea of handling both in the `BouncyCastleSecurityRegistrar` was wrong. And we don't need to de-couple the registrar name from the provider name. If you use bc-fips, you should use your own registrar (as you do), and it should be named BCFIPS. There is no need to change the value of `SecurityUtils.BC` though. Instead, there seem to be some cases where we don't guard BC dependencies enough, and those should be fixed in our code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
