I’m good either way…. Jeff
> On Jan 24, 2025, at 6:05 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > > Any other opinions? > > Gary > > On Tue, Jan 21, 2025 at 5:57 PM Emmanuel Lécharny <elecha...@apache.org> > wrote: >> >> And I agree. >> >> The change was an honest mistake, I really thought that nobody would ever >> instantiate this class, which should really be abstract. >> >> So whatever people chose: >> >> the vote is open, please cast a -1 if you think this should be fixed, it's a >> no brainer for me to cut another release. >> >> On 2025/01/21 15:20:52 Gary Gregory wrote: >>> My POV is to keep it simple, policy wise and not break binary compatibility >>> within a major line, instead of coming up with exceptions for this or that. >>> The API can be deprecated instead. >>> >>> I don't want to impose this POV here so it would be nice to hear from >>> others. >>> >>> Gary >>> >>> On Tue, Jan 21, 2025, 10:11 Emmanuel Lecharny <elecha...@gmail.com> wrote: >>> >>>> Hi Gary, >>>> >>>> I have added a default protected constructor to this class which should >>>> *never* be instanciated directly. >>>> >>>> >>>> Actually, I do think it should even be abstract. >>>> >>>> >>>> So, yes, I can revert the change, if really needed... >>>> >>>> Your call :-) >>>> >>>> Le 18/01/2025 à 13:48, Gary Gregory a écrit : >>>>> Hi Emmanuel, >>>>> >>>>> There is a binary break (run the default build with `mvn` by itself to >>>>> check, I used the src zip file): >>>>> >>>>> [ERROR] Failed to execute goal >>>>> com.github.siom79.japicmp:japicmp-maven-plugin:0.23.1:cmp >>>>> (default-cli) on project ftplet-api: There is at least one >>>>> incompatibility: >>>>> >>>> org.apache.ftpserver.ftplet.DefaultFtplet.DefaultFtplet():CONSTRUCTOR_LESS_ACCESSIBLE >>>>> -> [Help 1] >>>>> >>>>> I sent an email [1] a while back asking about our policy, if any, but >>>>> I did not get a clear reply. >>>>> >>>>> I use this component for tests, and I can adapt to this break, but I >>>>> want to be clear that this is a break and should at least be >>>>> documented, or reverted. >>>>> >>>>> WDYT? >>>>> >>>>> Gary >>>>> [1] https://lists.apache.org/thread/0d3pd01d0vz8qw9cq4doppqn69y3btp6 >>>>> >>>>> On Sat, Jan 18, 2025 at 5:14 AM Emmanuel Lecharny <elecha...@apache.org> >>>> wrote: >>>>>> Hi, >>>>>> >>>>>> a new version of Apache MINA FTPServer, version 1.2.1, is ready for a >>>> vote! >>>>>> >>>>>> It includes many fixes, and now depends on MINA core 2.2.4. >>>>>> >>>>>> Here is the list of fixes and modifications: >>>>>> >>>>>> o https://issues.apache.org/jira/projects/FTPSERVER-515: Bump Apache >>>>>> Log4j from 2.17.2 to 2.19.0 >>>>>> o https://issues.apache.org/jira/projects/FTPSERVER-510:Update Apache >>>>>> parent POM from 25 to 26 >>>>>> o >>>> https://issues.apache.org/jira/projects/FTPSERVER/issues/FTPSERVER-509: >>>>>> Enable GitHub Action build >>>>>> o https://issues.apache.org/jira/projects/FTPSERVER-506: Fix binary >>>>>> compatibility issues. >>>>>> o >>>> https://issues.apache.org/jira/projects/FTPSERVER/issues/FTPSERVER-499: >>>>>> FtpResponseEncoder is not thread safe >>>>>> o https://issues.apache.org/jira/projects/FTPSERVER-446: Implementing >>>>>> User Manager not possible in OSGi environment >>>>>> >>>>>> >>>>>> Otherwise, the following features have been added: >>>>>> o Support for SHA256 and SHA512 encryption >>>>>> o Use ThreadLocal for FtpResponseEncoder.ENCODER and SimpleDateFormat >>>>>> o Make build reproductible >>>>>> >>>>>> >>>>>> The newly approved Nexus has been used for the preparation of this >>>>>> release and all final artifacts are stored in a staging repository: >>>>>> >>>>>> https://repository.apache.org/content/repositories/orgapachemina-1109/ >>>>>> >>>>>> >>>>>> The distributions are available for download on : >>>>>> >>>>>> >>>> https://repository.apache.org/content/repositories/orgapachemina-1109/org/apache/ftpserver/ftpserver/1.2.1/ >>>>>> >>>>>> Packages can also be downloaded from: >>>>>> >>>>>> https://dist.apache.org/repos/dist/dev/mina/ftpserver/1.2.1/ >>>>>> >>>>>> Let us vote : >>>>>> [ ] +1 | Release Apache FtpServer 1.2.1 >>>>>> [ ] +/- | Abstain >>>>>> [ ] -1 | Do *NOT* release Apache FtpServer 1.2.1 >>>>>> >>>>>> Thanks ! >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Cordialement, >>>>>> Emmanuel Lécharny >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >>>>>> For additional commands, e-mail: dev-h...@mina.apache.org >>>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >>>>> For additional commands, e-mail: dev-h...@mina.apache.org >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >>>> For additional commands, e-mail: dev-h...@mina.apache.org >>>> >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org >> For additional commands, e-mail: dev-h...@mina.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
