artembilan commented on issue #700:
URL: https://github.com/apache/mina-sshd/issues/700#issuecomment-2733539036
Well, the `ClientSessionImpl` leads to this:
```
@Override
public final boolean isClosed() {
return state.get() == State.Closed;
}
```
So, calling the `ClientSessionImpl.close()` might not report the proper
state because it waits only for `CloseFuture`.
It is risky to keep it like that.
Similar race conditions may happen in other places.
I guess the complexity of the logic is because there is that third
`Graceful` state.
Well, with that we got two new (`Graceful`, `Immediate`) instead of
`Opened`, `Closed` before, but that's different story.
Thanks for pinging me about that shared session problem!
Will look into that today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
