[
https://issues.apache.org/jira/browse/SSHD-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Libor Svehlak updated SSHD-1343:
--------------------------------
Description:
JavaDoc on
https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelDataReceiver.java
states that if {{data()}} method queues received data then once data are
really consumed there has to be called
{{channel.getLocalWindow().consumeAndCheck(len)}}}. There are several issues
with this statement:
* Method {{consumeAndCheck(len)}} was removed in version 2.9.2 (commit
https://github.com/apache/mina-sshd/commit/0c8f9b22c3f4f26f4061210b6b9dd6ef729c9b97)
=> documentation is incorrect
* Even when we we call {{consume(len)}} method, it seems that window size is
not changed. Calling {{release(len)}} seems to fix this => is it the right
approach?
was:
JavaDoc on
https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelDataReceiver.java
states that if {{data()}} method queues received data then once data are
really consumed there has to be called
{{channel.getLocalWindow().consumeAndCheck(len)}}}. There are several issues
with this statement:
* Method {{consumeAndCheck(len)}} was removed in version 2.9.2 (commit
0c8f9b22c3f4f26f4061210b6b9dd6ef729c9b97) => documentation is incorrect
* Even when we we call {{consume(len)}} method, it seems that window size is
not changed. Calling {{release(len)}} seems to fix this => is it the right
approach?
> org.apache.sshd.server.channel.ChannelDataReceiver documentation issue
> ----------------------------------------------------------------------
>
> Key: SSHD-1343
> URL: https://issues.apache.org/jira/browse/SSHD-1343
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.15.0
> Reporter: Libor Svehlak
> Priority: Major
>
> JavaDoc on
> https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/channel/ChannelDataReceiver.java
> states that if {{data()}} method queues received data then once data are
> really consumed there has to be called
> {{channel.getLocalWindow().consumeAndCheck(len)}}}. There are several issues
> with this statement:
> * Method {{consumeAndCheck(len)}} was removed in version 2.9.2 (commit
> https://github.com/apache/mina-sshd/commit/0c8f9b22c3f4f26f4061210b6b9dd6ef729c9b97)
> => documentation is incorrect
> * Even when we we call {{consume(len)}} method, it seems that window size is
> not changed. Calling {{release(len)}} seems to fix this => is it the right
> approach?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
