tomaswolf commented on code in PR #716: URL: https://github.com/apache/mina-sshd/pull/716#discussion_r2022511057
########## sshd-core/src/main/java/org/apache/sshd/client/channel/PtyCapableChannelSession.java: ########## @@ -239,6 +255,21 @@ protected void doOpenPty() throws IOException { writePacket(buffer); } + if (xForwarding) { + if (debugEnabled) { + log.debug("doOpenPty({}) Send xForwarding request", this); + } + Buffer buffer = session.createBuffer(SshConstants.SSH_MSG_CHANNEL_REQUEST); + buffer.putInt(getRecipient()); + buffer.putString("x11-req"); + buffer.putBoolean(false); // want-reply + buffer.putBoolean(false); + buffer.putString("MIT-MAGIC-COOKIE-1"); Review Comment: RFC 4254 does not require MIT-MAGIC-COOKIE-1 to be used. User code will need to be able to configure the authentication protocol name and "cookie" (actually: arbitrary authentication data), for instance after having read it from the .Xauthority file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org