Gary, I have created the PR and it can be viewed here: https://github.com/apache/mina/pull/49
Please don't hesitate to reach out with any questions or concerns. I only applied these changes to the 2.1.X branch for now. If we want to port them to other releases, let me know. Ben ________________________________ From: Gary Gregory Sent: Monday, March 31, 2025 3:06 PM To: Ben Wagner Cc: dev Subject: Re: CCC and Close Notify Changes for Mina You don't often get email from garydgreg...@gmail.com. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> External: Pause and review the sender's email address, any URLs before clicking links, opening attachments, or following requests. When in doubt, contact the Service Desk. Ben, You'll need to create a pull request. Gary On Mon, Mar 31, 2025, 19:52 Ben Wagner <ben.wag...@fortra.com<mailto:ben.wag...@fortra.com>> wrote: Hi Gary, Looks like I need write access to the Mina repository on GitHub in order to push up my code. My username on GitHub is 'b-wagner'. Let me know if you need any more info. Ben ________________________________ From: Gary Gregory <garydgreg...@gmail.com<mailto:garydgreg...@gmail.com>> Sent: Saturday, March 29, 2025 3:23 AM To: Ben Wagner <ben.wag...@fortra.com<mailto:ben.wag...@fortra.com>> Subject: Fwd: CCC and Close Notify Changes for Mina You don't often get email from garydgreg...@gmail.com<mailto:garydgreg...@gmail.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> External: Pause and review the sender's email address, any URLs before clicking links, opening attachments, or following requests. When in doubt, contact the Service Desk. Mailer issues on our end... ---------- Forwarded message --------- From: Gary Gregory <garydgreg...@gmail.com<mailto:garydgreg...@gmail.com>> Date: Thu, Mar 27, 2025, 15:55 Subject: Re: CCC and Close Notify Changes for Mina To: Ben Wagner <ben.wag...@fortra.com.invalid> Cc: dev <dev@mina.apache.org<mailto:dev@mina.apache.org>> Hello Ben, I think the best path forward would be for you to provide a pull request on GitHub with unit tests that cover the new functionality. Gary On Thu, Mar 27, 2025, 15:31 Ben Wagner <ben.wag...@fortra.com.invalid> wrote: Hello, Our team has been maintaining a fork of Apache's ftpserver and, in turn, a fork of Apache Mina for well over a decade. The primary reason for forking Mina was to implement Clear Command Channel (CCC) and Close Notify support for FTPS, which are not natively supported. Over the years, we have kept our Mina fork up to date with the latest 2.1.x releases—including recently updating to 2.1.10 to mitigate the CVE. However, maintaining these forks has introduced unnecessary overhead, so we’re reaching out to explore whether our custom Mina changes could be merged into the main project. If that’s not feasible, we’d appreciate any guidance on how we might integrate our changes without maintaining a separate fork. Our modifications in Mina are limited to SslHandler and SslFilter. The modifications were put in place over 14 years ago and have not been altered since. If it would be helpful, I’d be happy to open a PR so you can review the changes and provide feedback. I also understand Mina is simply a network application framework and implementing FTPS-specific logic for CCC and Close Notify likely doesn't align with the project, but that is where our custom changes are located so I thought I'd start there. Additionally, a former member of our team previously opened a ticket on ASF Jira requesting CCC command support for ftpserver: FTPSERVER-411<https://issues.apache.org/jira/browse/FTPSERVER-411>. While this was never implemented in the main project, we’ve had it running successfully in our fork for some time. Would you be open to reviewing our changes to see if they align with the project’s direction? Let us know how you’d like to proceed. Looking forward to your thoughts, and thanks for your time! Ben Wagner
