raajeive commented on code in PR #726:
URL: https://github.com/apache/mina-sshd/pull/726#discussion_r2042806157
##########
sshd-core/src/main/java/org/apache/sshd/client/session/ClientSession.java:
##########
@@ -304,10 +311,10 @@ default void executeRemoteCommand(
ClientChannel channel = createExecChannel(command, charset, null,
Collections.emptyMap())) {
channel.setOut(channelOut);
channel.setErr(channelErr);
- channel.open().await(); // TODO use verify and a configurable
timeout
- // TODO use a configurable timeout
- Collection<ClientChannelEvent> waitMask =
channel.waitFor(REMOTE_COMMAND_WAIT_EVENTS, 0L);
+ channel.open().verify(commandTimeoutMillis, TimeUnit.MICROSECONDS);
+
+ Collection<ClientChannelEvent> waitMask =
channel.waitFor(REMOTE_COMMAND_WAIT_EVENTS, commandTimeoutMillis);
Review Comment:
Implemented the logic you suggested, can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
