tomaswolf commented on issue #879: URL: https://github.com/apache/mina-sshd/issues/879#issuecomment-3837371939
That `cause != null` was introduced in 2018 in commit 169ff4e4, which references [SSHD-792](https://issues.apache.org/jira/browse/SSHD-792), which on the face of it doesn't have anything to do with channel closing. Code archeology didn't help this time to understand why that change was made :-( . Seems to me it should just and simply be `false`. (I.e., always try to close the channel gracefully.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
