tomaswolf commented on issue #904: URL: https://github.com/apache/mina-sshd/issues/904#issuecomment-4798069865
> the id and recipient are not unique Hmmm. True for client sessions. Printing the peer address doesn't help for client sessions if you have multiple sessions with the same user to the same server. For client sessions, it might help to include the locally bound port. Instead of adding code to deal with MDC through thread locals (which I'd prefer not to have because of the concern mentioned above) we could maybe think about ways to customize `SessionHelper.toString()` and possibly the channels' `toString()` method. Of course you could do so already by subclassing `ClientSessionImpl` (and the factory), but that's tedious. And more tedious to do for channels. But if the library had a simple way to configure this, it might be good enough for this purpose and less risky and simpler to implement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
