tomaswolf commented on PR #916: URL: https://github.com/apache/mina-sshd/pull/916#issuecomment-5801963174
PMD complains about ``` [WARNING] PMD Failure: org.apache.sshd.common.io.nio2.Nio2DefaultIoWriteFuture:45 Rule:MissingOverride Priority:3 The method 'setException(Throwable)' is missing an @Override annotation.. [WARNING] PMD Failure: org.apache.sshd.common.session.helpers.PendingWriteFuture:49 Rule:MissingOverride Priority:3 The method 'setException(Throwable)' is missing an @Override annotation.. ``` Please also give the commit a meaningful commit message. We reference the issue in the title. Something like ``` GH-644: cancel writes of SFTP messages on timeout When SftpMessage.waitUntilSent() times out, the write must be canceled. Otherwise later writes when the SFTP session and the channel are closed may encounter a WritePendingException. - Make IoWriteFuture cancellable and preserve cancellation options in write verification. - Cancel the SFTP write future when waitUntilSent() times out. - Propagate cancellation to packet-level and window-buffered writes so canceled operations cannot resume later. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
