the-thing opened a new pull request, #67: URL: https://github.com/apache/mina/pull/67
https://github.com/apache/mina/actions/runs/35831174047/job/107083881501 `org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddress` sometimes fails due to additional log event sneaking in without remote address: https://github.com/apache/mina/blob/0813a77e5e1206000dffa647e7b384c88fd5b900/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java#L702 There are already some comments about logging in this file causing problems with `MdcInjectionFilterTest` https://github.com/apache/mina/blob/0813a77e5e1206000dffa647e7b384c88fd5b900/mina-core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java#L684 The disposing sessions log is quite new. **Changes** - filter log events `org.apache.mina.filter.logging.MdcInjectionFilterTest#testOnlyRemoteAddress` coming from `IoProcessor` logger The test still processes and verifies `org.apache.mina.core.filterchain.IoFilter` events such as: ``` Firing a SESSION_CREATED event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_CREATED event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent sessionCreated / org.apache.mina.filter.logging.MdcInjectionFilterTest sessionCreated / org.apache.mina.filter.logging.MdcInjectionFilterTest Event SESSION_CREATED has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event SESSION_CREATED has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_OPENED event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_OPENED event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent DummyIoFilter.sessionOpened / org.apache.mina.filter.logging.MdcInjectionFilterTest DummyIoFilter.sessionOpened / org.apache.mina.filter.logging.MdcInjectionFilterTest sessionOpened / org.apache.mina.filter.logging.MdcInjectionFilterTest sessionOpened / org.apache.mina.filter.logging.MdcInjectionFilterTest Event SESSION_OPENED has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event SESSION_OPENED has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_RECEIVED event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_RECEIVED event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Processing a MESSAGE_RECEIVED for session 1 / org.apache.mina.filter.codec.ProtocolCodecFilter Processing a MESSAGE_RECEIVED for session 3 / org.apache.mina.filter.codec.ProtocolCodecFilter decode / org.apache.mina.filter.logging.MdcInjectionFilterTest decode / org.apache.mina.filter.logging.MdcInjectionFilterTest messageReceived-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageReceived-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageReceived-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageReceived-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest encode / org.apache.mina.filter.logging.MdcInjectionFilterTest encode / org.apache.mina.filter.logging.MdcInjectionFilterTest Firing a WRITE event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a WRITE event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event WRITE has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent encode / org.apache.mina.filter.logging.MdcInjectionFilterTest Event WRITE has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a WRITE event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent encode / org.apache.mina.filter.logging.MdcInjectionFilterTest Firing a WRITE event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event WRITE has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event WRITE has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a EXCEPTION_CAUGHT event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a EXCEPTION_CAUGHT event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent exceptionCaught / org.apache.mina.filter.logging.MdcInjectionFilterTest exceptionCaught / org.apache.mina.filter.logging.MdcInjectionFilterTest Event EXCEPTION_CAUGHT has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event EXCEPTION_CAUGHT has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event MESSAGE_RECEIVED has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event MESSAGE_RECEIVED has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_SENT event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_SENT event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent messageSent-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest Event MESSAGE_SENT has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event MESSAGE_SENT has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_SENT event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a MESSAGE_SENT event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent messageSent-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-1 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest messageSent-2 / org.apache.mina.filter.logging.MdcInjectionFilterTest Event MESSAGE_SENT has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event MESSAGE_SENT has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_IDLE event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_IDLE event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent sessionIdle / org.apache.mina.filter.logging.MdcInjectionFilterTest sessionIdle / org.apache.mina.filter.logging.MdcInjectionFilterTest Firing a CLOSE event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Firing a CLOSE event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event CLOSE has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event CLOSE has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event SESSION_IDLE has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent Event SESSION_IDLE has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_CLOSED event for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Firing a SESSION_CLOSED event for session 1 / org.apache.mina.core.filterchain.IoFilterEvent sessionClosed / org.apache.mina.filter.logging.MdcInjectionFilterTest sessionClosed / org.apache.mina.filter.logging.MdcInjectionFilterTest Event SESSION_CLOSED has been fired for session 3 / org.apache.mina.core.filterchain.IoFilterEvent Event SESSION_CLOSED has been fired for session 1 / org.apache.mina.core.filterchain.IoFilterEvent ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
