elecharny commented on PR #72: URL: https://github.com/apache/mina/pull/72#issuecomment-5934327697
The difficulty with AbstractBindTest is that it call the `createSocketAddress` class from one of it's inherited classes, and it requires a port, which has not yet be selected, because we want to do that in the `AcceptorBindUtil.tryBind` call. And when the Acceptor is bound we can't anymore store the LocalAddress into it. A solution would be to remove the `AbstractBindTest` class and move its code in the three test classes that inherit from it. A bit heavy but it would give the opportinity to properly handle the localAddress accordingy to the acceptor type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
