the-thing commented on PR #74:
URL: https://github.com/apache/mina/pull/74#issuecomment-5947042991
> Nah, it's simpler that that. This part of the code recreate a socket
address:
>
> ```
> ...
> int port = AcceptorBindUtil.tryBind(acceptor);
> InetSocketAddress address = new InetSocketAddress("127.0.0.1",
port);
> ...
> ```
>
> Changing the code to:
>
> ```
> ...
> int port = AcceptorBindUtil.tryBind(acceptor);
> InetSocketAddress address = acceptor.getLocalAddress() ;
> ...
> ```
>
> fixes the test. (I committed the code)
Ok. So you proposed patch is doing something else. You always try a new
port. The question is what was the intention of the original test (no comments
and badly named test method).
If reusing the same port is not crucial here than it is good patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
