etnt commented on code in PR #932:
URL: https://github.com/apache/mina-sshd/pull/932#discussion_r4336464388
##########
sshd-common/src/main/java/org/apache/sshd/common/config/keys/KeyUtils.java:
##########
@@ -167,6 +170,11 @@ public final class KeyUtils {
static {
+ for (MLDSAParameterSets params : MLDSAParameterSets.values()) {
+ if (SecurityUtils.isMLDSASupported(params.getJceName())) {
+ registerPublicKeyEntryDecoder(new
MLDSAPublicKeyDecoder(params));
+ }
+ }
Review Comment:
the ML-DSA public key decoders are now registered unconditionally. Decoding
or key-factory use fails with a GeneralSecurityException when no provider is
available, instead of the decoders being missing for good if a provider is
added late.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]