Thanks Patrick, we will follow your guidance and advices to fix those
issues, Thanks.

On 5/6/2016 9:50 AM, Patrick Hunt wrote:
> -1
>
> There are a number of files missing licenses. The easiest way to
> find/fix these, and keep them from coming up again, is to use the
> Apache RAT tool: http://creadur.apache.org/rat/
>
> I ran it manually (you should integrate it into your maven pom) on the
> source repository and found the following "unapproved licenses"
> (typically means the file doesn't have a license boilerplate embedded
> in it):
>
> ----
>   ./README.md
>   ./mnemonic-collections/pom.xml
>   ./mnemonic-collections/proguard.conf
>   ./mnemonic-collections/src/test/resources/testng.xml
>   ./mnemonic-core/pom.xml
>   ./mnemonic-core/proguard.conf
>   ./mnemonic-core/src/main/assembly/assembly.xml
>   
> ./mnemonic-core/src/main/resources/META-INFO/services/javax.annotation.processing.Processor
>   ./mnemonic-core/src/test/resources/testng.xml
>   ./mnemonic-examples/pom.xml
>   ./mnemonic-memory-services/pom.xml
>   ./mnemonic-memory-services/mnemonic-nvml-vmem-service/pom.xml
>   
> ./mnemonic-memory-services/mnemonic-nvml-vmem-service/src/main/native/CMakeLists.txt
>   
> ./mnemonic-memory-services/mnemonic-nvml-vmem-service/src/main/native/config.h.in
>   
> ./mnemonic-memory-services/mnemonic-nvml-vmem-service/src/main/resources/META-INF/services/org.apache.mnemonic.service.allocatorservice.VolatileMemoryAllocatorService
>   ./mnemonic-memory-services/mnemonic-pmalloc-service/pom.xml
>   
> ./mnemonic-memory-services/mnemonic-pmalloc-service/src/main/native/CMakeLists.txt
>   
> ./mnemonic-memory-services/mnemonic-pmalloc-service/src/main/native/config.h.in
>   
> ./mnemonic-memory-services/mnemonic-pmalloc-service/src/main/resources/META-INF/services/org.apache.mnemonic.service.allocatorservice.NonVolatileMemoryAllocatorService
> ----
>
> Please see: 
> http://incubator.apache.org/guides/releasemanagement.html#release-legal-audit
>
>
> Also the build is failing for me. A simple "mvn clean" resulted in the
> following:
>
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Mnemonic Project Parent POM ........................ SUCCESS [  2.276 
> s]
> [INFO] mnemonic-core ...................................... SUCCESS [  0.002 
> s]
> [INFO] mnemonic-collections ............................... SUCCESS [  0.001 
> s]
> [INFO] mnemonic-examples .................................. SUCCESS [  0.002 
> s]
> [INFO] mnemonic-memory-services ........................... SUCCESS [  0.002 
> s]
> [INFO] mnemonic-nvml-vmem-service ......................... FAILURE [  2.097 
> s]
> [INFO] mnemonic-pmalloc-service ........................... SKIPPED
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 4.593 s
> [INFO] Finished at: 2016-05-06T09:47:06-07:00
> [INFO] Final Memory: 11M/186M
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project mnemonic-nvml-vmem-service:
> Could not resolve dependencies for project
> org.apache.mnemonic:mnemonic-nvml-vmem-service:jar:0.1.2-incubating:
> Could not find artifact
> org.apache.mnemonic:mnemonic-core:jar:0.1.2-incubating in central
> (https://repo1.maven.org/maven2) -> [Help 1]
> [ERROR]
>
>
>
> A few nits:
>
> 1) in the email it says
>
> "Release artifacts are signed with the following key" but that's not
> true. Looks to me like the code signing key is in KEYS, I don't see
> your personal garyw.asc being used for anything?
>
> 2) you are confusing release versions and release candidates.
> Typically you want to put together a "0.1.0" release candidate 1, then
> if necessary release candidate 2, 3 and so on. The version number
> should stay the same. Eventually you will have a "0.1.0" release.
>
> Patrick
>
> On Thu, May 5, 2016 at 7:18 PM, Gary <ga...@apache.org> wrote:
>> Hi all,
>>
>> I apologize to trigger JIRA many times due to update the field of "fix
>> version/s" on all relevant issues.
>>
>> This is a call for a discussion releasing Apache Mnemonic
>> 0.1.2-incubating, release candidate 1. This
>> is the first release of Mnemonic.
>>
>> The source tarball, including signatures, digests, etc. can be found at:
>> https://dist.apache.org/repos/dist/dev/incubator/mnemonic/0.1.2-incubating-rc1/src/
>>
>> The tag to be voted upon is v0.1.2-incubating:
>> https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=shortlog;h=refs/tags/v0.1.2-incubating
>>
>> The release hash is 8b26f1480bd4d3fd9ced65f6598d5fa1378015ad:
>> https://git-wip-us.apache.org/repos/asf?p=incubator-mnemonic.git;a=commit;h=8b26f1480bd4d3fd9ced65f6598d5fa1378015ad
>>
>> Release artifacts are signed with the following key:
>> https://people.apache.org/keys/committer/garyw.asc
>>
>> KEYS file available:
>> https://dist.apache.org/repos/dist/dev/incubator/mnemonic/KEYS
>>
>> For information about the contents of this release, see:
>> https://dist.apache.org/repos/dist/dev/incubator/mnemonic/0.1.2-incubating-rc1/CHANGES.txt
>>
>> Thanks,
>> Gary
>>
>>
>>
>>


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to