[
https://issues.apache.org/jira/browse/MNEMONIC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150962#comment-16150962
]
ASF GitHub Bot commented on MNEMONIC-304:
-----------------------------------------
Github user bigdata-memory commented on a diff in the pull request:
https://github.com/apache/incubator-mnemonic/pull/66#discussion_r136635829
--- Diff:
mnemonic-core/src/main/java/org/apache/mnemonic/ParameterHolder.java ---
@@ -105,4 +114,20 @@ public void setHandler(long h) {
public long getHandler() {
return handler;
}
+
+ public void setGenericTypeAndEntityFactoryProxyPair(DurableType[] d,
EntityFactoryProxy[] e) {
+ dpt = new ImmutablePair<DurableType[], EntityFactoryProxy[]>(d, e);
+ }
+
+ public DurableType[] getGenericTypeFromPair() {
--- End diff --
please remove the suffix "FromPair" would be more concise.
> Add support for Pair to ParameterHolder class to handle optional parameters
> ---------------------------------------------------------------------------
>
> Key: MNEMONIC-304
> URL: https://issues.apache.org/jira/browse/MNEMONIC-304
> Project: Mnemonic
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.8.0-incubating
> Reporter: Yanhui Zhao
> Assignee: Yanhui Zhao
> Priority: Minor
> Labels: features
>
> Some test cases need to pass Pair as parameters when creating durable class.
> Current ParameterHolder class doesn't have the support for this feature.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
