Sounds like it's not something to consider for this release. I checked out the rest of the artifact and it seemed OK to me - +1.
Regards, Patrick On Tue, Nov 7, 2017 at 11:29 AM, Gang(Gary) Wang <ga...@apache.org> wrote: > Hi Henry, > > Thank you very much for the clarification, It's my bad to misunderstand > the meanings of regression and feature. > > We have not yet tried to compile the project with Java9 before, the issue > found by Patrick make me realize that the JDK9 has been GA released. > > So we are fine with this release candidate, right? Thanks! > > Hi Patrick, > > I'm really sorry for the confusion. > > Best. > Gary > > > > > > > > > > On Tue, Nov 7, 2017 at 10:12 AM, Henry Saputra <henry.sapu...@gmail.com> > wrote: > >> I would argue this is not a blocker since the pom.xml define the target >> JVM: >> >> https://github.com/apache/incubator-mnemonic/blob/master/pom.xml#L104 >> >> Gary, when you said regression, did you mean it was working with Java9 >> before and now it was not? >> If it has not been working with Java9 from beginning this should not be >> release blocker. >> >> - Henry >> >> On Mon, Nov 6, 2017 at 3:24 PM, Johnu <johnugeorge...@gmail.com> wrote: >> >> > Hi Patrick, >> > Thanks for the reply. Currently,Mnemonic doesn't support >> > Java 9 due to incompatible interface changes. We verified the release >> with >> > Java8. (Created https://issues.apache.org/jira/browse/MNEMONIC-401) >> If it >> > is a blocker, I will cancel the rc vote. Else, we will fix it in the >> next >> > release. Please let us know. >> > >> > >> > Thanks, >> > Johnu >> > >> > On Nov 6, 2017 11:38 AM, "Gang(Gary) Wang" <ga...@apache.org> wrote: >> > >> > > Hi Patrick, >> > > >> > > Thank you very much for the guidance and we will try to figure out >> how to >> > > fix this issue you found. >> > > >> > > Best, >> > > Gary. >> > > >> > > >> > > >> > > >> > > On Mon, Nov 6, 2017 at 11:02 AM, Patrick Hunt <ph...@apache.org> >> wrote: >> > > >> > > > ic. If it's a regression I would personally terminate the rc vote, >> fix >> > > it, >> > > > and then cut a new rc. But that's my personal preference, I don't >> > believe >> > > > there's any specific rule wrt this type of thing. Would suck for >> folks >> > > > using it certainly. >> > > > >> > > > Patrick >> > > > >> > > > On Mon, Nov 6, 2017 at 9:56 AM, Gary Wong <qich...@gmail.com> >> wrote: >> > > > >> > > > > Hi Patrick, >> > > > > >> > > > > I think it is a regression, not a feature. Thanks. >> > > > > >> > > > > Best, >> > > > > Gary. >> > > > > >> > > > > >> > > > > On Mon, Nov 6, 2017 at 9:32 AM, Patrick Hunt <ph...@apache.org> >> > wrote: >> > > > > >> > > > > > Is this a feature or a regression? >> > > > > > >> > > > > > Patrick >> > > > > > >> > > > > > On Mon, Nov 6, 2017 at 9:18 AM, Johnu <johnugeorge...@gmail.com >> > >> > > > wrote: >> > > > > > >> > > > > > > Hi Patrick and other mentors, >> > > > > > > Can you please vote for the release? >> > > > > > > >> > > > > > > Thanks, >> > > > > > > Johnu >> > > > > > > >> > > > > > > On Fri, Nov 3, 2017 at 2:14 PM, Gang(Gary) Wang < >> > ga...@apache.org> >> > > > > > wrote: >> > > > > > > > Looks it is caused by the new JDK, we need to investigate >> this >> > > > issue >> > > > > > > > further to make it compatible with older JDK version if we >> fix >> > it >> > > > for >> > > > > > new >> > > > > > > > JDK. let me create a JIRA ticket for this issue, and could >> be a >> > > > > blocker >> > > > > > > for >> > > > > > > > this release candidate? Thanks!. >> > > > > > > > >> > > > > > > > On Fri, Nov 3, 2017 at 1:54 PM, Patrick Hunt < >> ph...@apache.org >> > > >> > > > > wrote: >> > > > > > > > >> > > > > > > >> $java -version >> > > > > > > >> java version "9.0.1" >> > > > > > > >> Java(TM) SE Runtime Environment (build 9.0.1+11) >> > > > > > > >> Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed >> mode) >> > > > > > > >> >> > > > > > > >> On Fri, Nov 3, 2017 at 1:11 PM, Gang(Gary) Wang < >> > > ga...@apache.org >> > > > > >> > > > > > > wrote: >> > > > > > > >> >> > > > > > > >> > Hi Patrick, which version of the JDK you are using to >> > compile? >> > > > > > > >> > >> > > > > > > >> > $java -version >> > > > > > > >> > >> > > > > > > >> > Best, >> > > > > > > >> > Gary. >> > > > > > > >> > >> > > > > > > >> > >> > > > > > > >> > On Fri, Nov 3, 2017 at 9:28 AM, Patrick Hunt < >> > > ph...@apache.org> >> > > > > > > wrote: >> > > > > > > >> > >> > > > > > > >> > > Doesn't seem to be compiling for me: >> > > > > > > >> > > >> > > > > > > >> > > [ERROR] Failed to execute goal >> > > > > > > >> > > org.apache.maven.plugins:maven-compiler-plugin:3.3: >> > compile >> > > > > > > >> > > (default-compile) on project mnemonic-core: Compilation >> > > > failure: >> > > > > > > >> > > Compilation failure: >> > > > > > > >> > > [ERROR] >> > > > > > > >> > > /Users/phunt/Downloads/m/apache-mnemonic-0.10.0- >> > > > > > > >> > > incubating/mnemonic-core/src/ >> > main/java/org/apache/mnemonic/ >> > > > > > > >> > > SysMemAllocator.java:[25,15] >> > > > > > > >> > > error: cannot find symbol >> > > > > > > >> > > [ERROR] symbol: class Cleaner >> > > > > > > >> > > [ERROR] location: package sun.misc >> > > > > > > >> > > [ERROR] >> > > > > > > >> > > /Users/phunt/Downloads/m/apache-mnemonic-0.10.0- >> > > > > > > >> > > incubating/mnemonic-core/src/ >> > main/java/org/apache/mnemonic/ >> > > > > > > >> > > SysMemAllocator.java:[86,12] >> > > > > > > >> > > error: cannot find symbol >> > > > > > > >> > > [ERROR] symbol: class Cleaner >> > > > > > > >> > > [ERROR] >> > > > > > > >> > > /Users/phunt/Downloads/m/apache-mnemonic-0.10.0- >> > > > > > > >> > > incubating/mnemonic-core/src/ >> > main/java/org/apache/mnemonic/ >> > > > > > > >> > > SysMemAllocator.java:[86,31] >> > > > > > > >> > > error: cannot find symbol >> > > > > > > >> > > [ERROR] -> [Help 1] >> > > > > > > >> > > [ERROR] >> > > > > > > >> > > >> > > > > > > >> > > On Mon, Oct 30, 2017 at 9:26 PM, Johnu George < >> > > > jo...@apache.org >> > > > > > >> > > > > > > >> wrote: >> > > > > > > >> > > >> > > > > > > >> > > > Hi all, >> > > > > > > >> > > > >> > > > > > > >> > > > This is a call for a releasing Apache Mnemonic >> > > > > > > >> > > > 0.10.0-incubating, release candidate rc1. This >> > > > > > > >> > > > is the new release of Mnemonic incubating. >> > > > > > > >> > > > >> > > > > > > >> > > > The source tarball, including signatures, digests, >> etc. >> > > can >> > > > be >> > > > > > > found >> > > > > > > >> > at: >> > > > > > > >> > > > https://dist.apache.org/repos/ >> > > dist/dev/incubator/mnemonic/0 >> > > > . >> > > > > > > >> > > > 10.0-incubating-rc1/src/ >> > > > > > > >> > > > >> > > > > > > >> > > > The tag to be voted upon is v0.10.0-incubating: >> > > > > > > >> > > > https://git-wip-us.apache.org/repos/asf?p=incubator- >> > > > > > > >> > > > mnemonic.git;a=shortlog;h=refs >> /tags/v0.10.0-incubating >> > > > > > > >> > > > >> > > > > > > >> > > > The release hash is 0e6cf3534b2f1a6407021e0d99073d >> > > > 794690f71b: >> > > > > > > >> > > > https://git-wip-us.apache.org/repos/asf?p=incubator- >> > > > > > > >> > > > mnemonic.git;a=commit;h=0e6cf3 >> 534b2f1a6407021e0d99073d >> > > > > > 794690f71b >> > > > > > > >> > > > >> > > > > > > >> > > > Release artifacts are signed with the following key: >> > > > > > > >> > > > https://dist.apache.org/repos/ >> > > dist/dev/incubator/mnemonic/ >> > > > > KEYS >> > > > > > > >> > > > >> > > > > > > >> > > > KEYS file available: >> > > > > > > >> > > > https://dist.apache.org/repos/ >> > > dist/dev/incubator/mnemonic/ >> > > > > KEYS >> > > > > > > >> > > > >> > > > > > > >> > > > For information about the contents of this release, >> see: >> > > > > > > >> > > > https://dist.apache.org/repos/ >> > > dist/dev/incubator/mnemonic/0 >> > > > . >> > > > > > > >> > > > 10.0-incubating-rc1/CHANGES.txt >> > > > > > > >> > > > >> > > > > > > >> > > > The vote will be open for ~72 hours. >> > > > > > > >> > > > Please download the release candidate and evaluate >> the >> > > > > necessary >> > > > > > > >> items >> > > > > > > >> > > > including checking hashes, signatures, build from >> > source, >> > > > and >> > > > > > > test. >> > > > > > > >> > The >> > > > > > > >> > > > please vote: >> > > > > > > >> > > > >> > > > > > > >> > > > [ ] +1 Release this package as >> apache-mnemonic-0.10.0- >> > > > > > incubating >> > > > > > > >> > > > [ ] +0 no opinion >> > > > > > > >> > > > [ ] -1 Do not release this package because... >> > > > > > > >> > > > >> > > > > > > >> > > > Thanks, >> > > > > > > >> > > > Johnu on behalf of the Apache Mnemonic (incubating) >> > > > community >> > > > > > > >> > > > >> > > > > > > >> > > >> > > > > > > >> > >> > > > > > > >> >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
