OK. I checked it! I'll check in soon. ======================================== Mitsutaka Amano MIRACLE LINUX CORPORATION ========================================
Loïc Minier wrote:
On Sun, Aug 24, 2008, Mitsutaka Amano wrote:* not sure why you kept: # FIXME: JLV: I really don't like all this sed usage, need to clean this up self.target.chroot("/bin/sed s+/boot/+/+g -i /boot/grub/menu.lst") in libs/InstallImage.py?Do you know history which is added?So what happens is that all files for the target image are stored in the same dir at the time where update-grub is run; so update-grub generates a menu.lst with "kernel /boot/vmfoo" entries. But on the target device, /boot is a separate partition, so in the past MIC would replace all "kernel" lines (and anything mentionning /boot) to use / instead of /boot. But you might recall you merged the change by Emmet to ship a /boot -> / symlink in the /boot partition: this makes the /boot/vmfoo entries work even when grub is on a separate partition: + if not os.path.exists("%s/boot/boot" % self.target.path): + os.symlink(".", "%s/boot/boot" % self.target.path) So if you have this patch, you don't need to worry about sedding /boot in menu.lst anymore. However, in the future, it would be best if instead of the symlink we convinced update-grub to generate a correct menu.lst: this could be achieved by mounting the target data as *two* partitions.
_______________________________________________ dev mailing list [email protected] https://www.moblin.org/mailman/listinfo/dev
