Do you mean that the improvement cuts a second off of the system startup, since mutter is started as the system does? If yes, how does it make cache for nbtk/ccss before or during system booting? I think all the caches are cleaned when the system is shutdown.
I guess that the system will be more efficient after booted, such as displaying "myzone" when the associated button is clicked. Mutter draws the drop-down panel each time the panel button is clicked. So if the contents/styles are cached, it should speed up the processing. But it is amazing that one second is cut off. And we don't think it is slow before. Any idea? Thanks, Yanshuang -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Robert Staudinger Sent: 2009年6月2日 6:54 To: [email protected] Cc: [email protected] Subject: Re: [Moblin Dev] mutter-moblin / ccss speedup ... Hi Michael, On Tue, 2009-05-26 at 08:01 -0700, Michael Meeks wrote: > Hi there, > > Please find attached an horrible hack that cuts a second off my mutter > startup or so. It reduces the number of nbtk_stylable_get_style_id calls > from 235k to 12k and the same for nbtk_stylable_get_style_class calls. > > For some obscure reason (and perhaps the real fix is here) - we call > each of these methods around 20 times each, back to back ;-) so the > cache helps rather a lot. > > This reduces the cost of 'get_style_id' and 'get_style_class' from 20%+ > to less than 1% of startup [ though there is a mismatch in those two > numbers locally ;-] Be great to get some testing / input from someone > who actually knows what is going on here ;-) > > It is of course possible that we see a lot more pain here because we > don't turn off type-checking in gobject [ something sure to cause > 'interesting' effects in the rest of the stack ;-], but hopefully it's a > win whatever. Thanks for the patch and reasoning. After some discussion with Thomas Wood I did a cache -- much along the lines what you did here for nbtk -- for libccss. My simplistic sysprofing indicates the time nbtk spends in libccss is down by around 30%. Best, Rob Sta. _______________________________________________ Moblin dev Mailing List [email protected] To manage or unsubscribe from this mailing list visit: https://lists.moblin.org/mailman/listinfo/dev or your user account on http://moblin.org once logged in. For more information on the Moblin Developer Mailing lists visit: http://moblin.org/community/mailing-lists _______________________________________________ Moblin dev Mailing List [email protected] To manage or unsubscribe from this mailing list visit: https://lists.moblin.org/mailman/listinfo/dev or your user account on http://moblin.org once logged in. For more information on the Moblin Developer Mailing lists visit: http://moblin.org/community/mailing-lists
