[ http://jira.codehaus.org/browse/MCOBERTURA-10?page=comments#action_59680 
] 

Joakim Erdfelt commented on MCOBERTURA-10:
------------------------------------------

I would welcome a more simple configuration setup. 

Here's an example of the current configuration ...

<check branchrate="80" linerate="70" haltonerror="true" totalbranchrate="80" 
totallinerate="70">
    <regex pattern="com.example.reallyimportant.*" branchrate="80" 
linerate="90"/>
    <regex pattern="com.example.boringcode.*" branchrate="40" linerate="30"/>
</check>

How would you propose a more simple solution?

(First Stab)

<check>
  <halt.on.error>true</halt.on.error>
  <rate.branch>80</rate.branch>
  <rate.branch.total>80</rate.branch.total>
  <rate.line>70</rate.line>
  <rate.line.total>70</rate.line.total>
  <patterns>
    <pattern>
      <regex>com.example.reallyimportant.*</regex>
      <rate.branch>80</rate.branch>
      <rate.total>90</rate.total>
    </pattern>
    <pattern>
      <regex>com.example.boringcode.*</regex>
      <rate.branch>40</rate.branch>
      <rate.total>30</rate.total>
    </pattern>
  </patterns>
</check>


> use standard configuration style for checks
> -------------------------------------------
>
>          Key: MCOBERTURA-10
>          URL: http://jira.codehaus.org/browse/MCOBERTURA-10
>      Project: Maven 2.x Cobertura Plugin
>         Type: Improvement

>     Reporter: Brett Porter
>     Assignee: Joakim Erdfelt
>      Fix For: 2.0

>
>
> currently it uses ant style:
> <check totallinerate="...">
>   <regex ... />
> </check>
> This would be confusing for Maven users. It should be:
> <check>
>   <totalLineRate>...</totalLineRate>
>   <regex>
>     ...
>   </regex>
> </check>
> It is also much easier to code in Java than the current plexus configuration 
> munging
>   

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to