Thanks for the feedback. So is the proposed change to be to make the
dir locations File objects and prepend the ${basedir} to them? If so I
can do this and then do the official release ;-)
Comments?
Thanks,
Jeff
Kenney Westerhof wrote:
> On Tue, 11 Apr 2006, Kostis Anagnostopoulos wrote:
>
> Hi Kostis,
>
> The mojo-dev list is the correct place to post questions, so other members
> can help you too. I don't know if there is a [EMAIL PROTECTED] list,
> but if there is, that one should be used for user questions. :)
>
>> Hi Jeff Genender,
>>
>> I'm addressing you this mail since your are the sole maintainer of the
>> org.codehaus.mojo/jaxb2-maven-plugin. I'm not sure whether i should
>> have post it solely to the codehous mailing lists...hope i choose
>> right :-).
>>
>>
>> i'm using your jaxb2 maven plugin as is and as a sample code for other
>> maven2 plugins, and i'm gratefull for your effort.
>>
>> I have found 2 minor issues regarding the formentioned maven2 plugin.
>>
>> 1. Placement of the staleFlag file:
>> ------------------------------------------------
>> By default the stale file always goes to ${basedir}/src/main/xjb
>> When the outputDirectory changes it would be nice not to re-generate
>> that directory and use the outputDirectory instead.
>>
>
> I think you're using an old version, because the jaxb2-maven-plugin places
> the staleFile to ${project.build.directory}/jaxb-source/.staleFlag
> where ${project.build.directory} is target/.
>
>> 2. Dir params are not specified relative to ${basedit}:
>> ---------------------------------------------------------------------------
>> The dirs (schemaDir, BindigDir, OutputDir) are not defined relative to
>> ${basedir}
>> and it may have strange behavior. When working at CLI i think it is ok.
>> But from eclipse (meven2), everything ends up in my home folder.
>
> Correct, the parameters are still 'String's, not 'File's. That should be
> easily fixable. Two solutions until the next release:
>
> 1) use the default locations, they work
> 2) prepend ${basedir} to those path configurations in the POM
>
> -- Kenney
>
>> I thing it would be better if:
>> If <dir> is absolute, use it as is
>> if <dir> is relative, the base it on ${basedir}.
>>
>> I don't have much maven2 experience so correct me if i'm assuming
>> something wrong here.
>>
>> --
>>
>> I have tried to fix those issues and i include them to you as a patch,
>> for reference.
>> Notice that i've made the staleFlag file ReadOnly. This may require
>> more thought.
>>
>> The command used to build the patch was issued inside the
>> src/main/java/org/codehaus/mojo/jaxb2-maven-plugin directory:
>> svn diff XjcMojo.java >jaxb2-maven-plugin-rel_dirs-stale_flag.patch
>> --
>>
>> Hope it didn't bother to contact you,
>> forgive my bad english,
>>
>> Kostis Anagnostopoulos
>>
>
> --
> Kenney Westerhof
> http://www.neonics.com
> GPG public key: http://www.gods.nl/~forge/kenneyw.key
