[ http://jira.codehaus.org/browse/MOJO-565?page=comments#action_83371 ] Trygve Laugstol commented on MOJO-565: --------------------------------------
I understood that part, and I've already applied the changes to the shell scripts. But from what I could read from the bat file it didn't change the behaviour in either way. Are the changed really required? I'm so lost without a windows machine to test this stuff on .. :( > [appassembler] scripts change the current directory therefore relative pathes > become invalid > -------------------------------------------------------------------------------------------- > > Key: MOJO-565 > URL: http://jira.codehaus.org/browse/MOJO-565 > Project: Mojo > Issue Type: Bug > Components: appassembler > Environment: Cygwin using both .bat and sh scripts > Reporter: Mathieu Champlon > Priority: Critical > Attachments: MOJO-565.patch > > > The scripts change the current directory in order to compute BASEDIR. > For example in the .bat : > :WinNTGetScriptDir > cd /d %0\..\.. > And in the shell script : > # Change directory to the basedir > cd "$BASEDIR" > This is definitly a bad idea at least for the following reason : relative > pathes become invalid. > The solution would be either not to use cd in order to retrieve BASEDIR or to > change the current directory back afterwards. > For the .bat file maybe something like the following would be enough (that's > what is in mvn.bat) : > :setPaths > set BASEDIR=%~dp0.. > And for the shell script (again this comes from the mvn script) : > saveddir=`pwd` > ... > cd "$saveddir" > I'll try and make a patch if a can find some time in the following days. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
