+1
-- Regards, Garvin LeClaire [EMAIL PROTECTED] On 3/11/07, Jason van Zyl <[EMAIL PROTECTED]> wrote:
On 11 Mar 07, at 1:24 PM 11 Mar 07, Jason Dillon wrote: > Just a general comment first... I do plan on weeding this guy out > and/or moving what its got to another shared place at sometime in > the nearish future. This was where I put all of the shared bits > for plugins which were in Geronimo Genesis and was used by plugins > that have migrated from there to Mojo (groovy-maven-plugin and > selenium-maven-plugin primarily, though some classes which were > provided here were simply duplicated in the retrotranslator-maven- > plugin). The other Maven plugins which we have at Geronimo (like > car-maven-plugin and geronimo-maven-plugin also make heavy use of > this codebase). > > I would like to eventually get most of this stuff moved into > components and/or into proper maven shared bits... but I did not > want to delay release of the plugins which use the stuff there > now. And I did not want to duplicate the classes. > > So, I'd still like to continue with this release and then (probably > with some of your help) I can figure out how to eventually make > this go away. > Sure, no problem. Just wanted to make sure you knew about the other stuff. Release away! Jason. > > On Mar 11, 2007, at 12:54 PM, Jason van Zyl wrote: >>> * Ant integration helpers >> >> We have maven-ant that we are using in the Ant Run plugin and Ant- >> based mojos. It would be nice not to have this cropping up in more >> then one place. >> >> http://svn.apache.org/repos/asf/maven/shared/trunk/maven-ant/ >> >>> * Logging adapters >> >> What kind of adapters? > > Maven log -> JCL > Ant log -> Maven log > > >>> * Nested artifact item resolution >> >> What is this? > > Support for plugins which have artifact-item like configuration, > and need to resolve them. Like this for example: > > ----8<---- > <plugin> > <groupId>org.codehaus.mojo.groovy</groupId> > <artifactId>groovy-maven-plugin</artifactId> > <executions> > <execution> > <configuration> > <classpath> > <element> > <groupId>commons-lang</groupId> > <artifactId>commons-lang</groupId> > </element> > </classpath> > <source> > <body> > // ... > </body> > </source> > </configuration> > </execution> > </executions> > </plugin> > ---->8---- > > >>> * Transitive dependency tree muck >> >> And this? > > Primarily this component: > > http://mojo.codehaus.org/plugin-support/apidocs/org/codehaus/ > mojo/pluginsupport/dependency/DependencyHelper.html > > Which makes it easier to get the transitive dependencies from a > project with a simple API. > > >>> * And a bunch of other little things >>> >> >> What else? > > I'd just peep at the javadocs... its not that big: > > http://mojo.codehaus.org/plugin-support/apidocs/index.html > > >> We have so much in the shared components in Maven, I just want to >> make sure we're not duplicating tons of stuff. Easy enough to get >> you access there. > > I understand. As mentioned above much of this was here because > plugin-support was the _shared_ area for Geronimo Genesis fluff... > and now I'm trying to move some (if not all) of the plugin bits > there to somewhere outside of Geronimo. > > I'd imagine at least a few things in here don't really have a > proper home elsewhere. Like MojoSupport... this is basically a wee > bit of framework to setup a Mojo.execute() that handles any > exception, reducing all of the try/catch cruft in plugins (at the > expense of a slightly deeper stacktrace). This puppy also has many > helper methods on it which make dealing with the > 'org.apache.maven.artifact' APIs easier IMO (less code in impl > Mojos). Some of this I'd like to have put into a component, but I > have yet to figure out how to get everything needed to be injected > into the component. > > * * * > > Anyways, I'd be happy to look into consolidating into a shared > maven module and/or rewriting plugins to use existing shared bits > if they perform the same function... BUT, I'd like to release this > ASIS now so that the plugins which code against it now can be > released... else I fear it would push the releases of them out for > at least a few weeks (which will make at least a few people not so > happy). > > --jason > > > --------------------------------------------------------------------- > To unsubscribe from this list please visit: > > http://xircles.codehaus.org/manage_email > > --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
