[
http://jira.codehaus.org/browse/MEXEC-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89900
]
David Smiley commented on MEXEC-20:
-----------------------------------
I am also for the so called "second option" as you have described. The next
question is how long should the timeout be, if any? We could have the timeout
of the daemon join be small (say 4 seconds?) which would be plenty of time for
a well-behaved threaded app to quit, but not too long to hang it for an
annoying time period. Or we could timeout for much longer (20 secs?) which is
annoying and would cause developers to investigate the issue and fix it
(assuming they even can... that is, it is "there" code). In the latter case,
the developer can simply choose to configure the plug-in to not join.
~ David
> rethink the default thread management
> -------------------------------------
>
> Key: MEXEC-20
> URL: http://jira.codehaus.org/browse/MEXEC-20
> Project: Mojo Exec Plugin
> Issue Type: Improvement
> Affects Versions: 1.1
> Reporter: Jerome Lacoste
> Priority: Blocker
>
> Before 1.1 is released I want us to make a proper handling of threads in
> java:exec.
> Today the plugin does the following:
> 1- join non daemon threads
> 2- interrupt remaining threads
> 3- stop() all threads in group
> 1 is OK as that's the condition used by the VM for detecting when to stop().
> But I don't think we should enable 2 and 3 by default, because they don't
> represent what the VM does.
> The whole idea of cleaning up threads after running is because we are running
> the command in the same VM as maven and we don't want these unfinished
> threads to keep running. Thus we're forced to do things that are abnormal
> compared to normal execution.
> So what could we do ?
> I believe that the plugin is mostly used on the command line. In that case,
> not cleaning up is less of a problem.
> One proposed solution is to not perform point 2 and 3 by default and force
> the user to enable a flag to kill those threads.
> Any better idea ?
> See MEXEC-18 and MEXEC-6 for historic and discussions of the original
> implementation of the thread management in 1.1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
