[
http://jira.codehaus.org/browse/MWEBSTART-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerome Lacoste closed MWEBSTART-31.
-----------------------------------
Resolution: Fixed
Kevin. Great patch (code + test + javadoc + doc update). Feel free to send more
! :)
I've added your name in the pom, without an email. Let me know if you want me
to specify one.
> Allow version attribute to be included in jar resource element in JNLP file
> ---------------------------------------------------------------------------
>
> Key: MWEBSTART-31
> URL: http://jira.codehaus.org/browse/MWEBSTART-31
> Project: Maven 2.x Webstart Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-1
> Environment: n/a
> Reporter: Kevin Stembridge
> Assigned To: Jerome Lacoste
> Priority: Minor
> Fix For: 1.0-alpha-2
>
> Attachments: MWEBSTART-31-patch1.diff
>
>
> The JNLP spec allows a version attribute to appear in a jar resource element.
> E.G.
> {code:xml}
> <jnlp>
> ...
> <resources>
> ...
> <jar href="myResource-1.0.jar" version="1.0" />
> ...
> </resources>
> ...
> </jnlp>
> {code}
> But this is not currently supported by the plugin. It should be possible to
> specify, for each dependency to be included in the JNLP file as a jar
> resource, whether or not the version attribute is to be output. This would
> probably mean that the current way of including a dependency would have to
> change from this:
> {code:xml}
> <dependencies>
> <includes>
> <include>log4j:log4j</include>
> <include>commons-logging:commons-logging</include>
> </includes>
> </dependencies>
> {code}
> to something like this:
> {code:xml}
> <dependencies>
> <includes>
> <include>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <outputVersionFlag>true</outputVersionFlag>
> </include>
> <include>
> <groupId>commons-logging</groupId>
> <artifactId>commons-logging</artifactId>
> <outputVersionFlag>false</outputVersionFlag>
> </include>
> </includes>
> </dependencies>
> {code}
> It is very likely that developers will want to apply the same value of
> _outputVersionFlag_ to all dependencies. So for convenience, it would be a
> good idea to add a _defaultOutputVersionFlag_ to the Dependencies element.
> Jerome, let me know if you agree with this plan and I'll set about making a
> patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
