>- it would have been nice if the style changes had been done >separately. It makes reviewing of the patch harder.
Ok, I will care of it. >- why did you copy classes from plexus-utils into the plugin ? Is that >supposed to be permanent ? Because, I don't know if this 'patch' really solve the subprocess destruction. I want to be sure of it before making a plexus patch. At this time, my code detects the subprocess existence and calls the 'Process.detroy' method, but it doesn't seem to really kill the subprocess. Philippe -----Original Message----- From: Jerome Lacoste [mailto:[EMAIL PROTECTED] Sent: vendredi 6 avril 2007 21:49 To: [email protected] Subject: [mojo-dev] Re: [mojo-scm] [3870] trunk/mojo/mojo-sandbox/fitnesse-maven-plugin: Kill fitness subprocess when maven build is stopped. On 6 Apr 2007 18:16:34 -0000, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Revision 3870 Author pkernevez Date 2007-04-06 13:16:32 -0500 (Fri, 06 Apr > 2007) > Log Message Kill fitness subprocess when maven build is stopped. > MOJO-725 I followed this issue because I think this is a general issue with Process that might be external executed by maven. Some remarks: - it would have been nice if the style changes had been done separately. It makes reviewing of the patch harder. - why did you copy classes from plexus-utils into the plugin ? Is that supposed to be permanent ? J --------------------------------------------------------------------- To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email
