[
http://jira.codehaus.org/browse/MOJO-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92655
]
Barrie Treloar commented on MOJO-731:
-------------------------------------
Your build is meant to be reproducible, hence these values should be in your
buildConfiguration\build.properties should contain all configs that should be
built.
Admittedly the current pde build only supports one config, that was all I
needed and I have not had time to look at fixing it.
The main reason for only allowing one configuration for a product build was to
avoid having to lookup how to attach multiple artifacts.
Remember all this mojo does is delegate to the pde build and takes the results
of this and installs it into your maven repository.
Is there a reason why you don't want to list your configurations in
buildConfiguration\build.properties?
> Config value <configuration>\<buildProperties>\<configs>="win32,win32,x86"
> has no effect on goal pde:attach
> -----------------------------------------------------------------------------------------------------------
>
> Key: MOJO-731
> URL: http://jira.codehaus.org/browse/MOJO-731
> Project: Mojo
> Issue Type: Bug
> Components: pde
> Environment: pde-maven-plugin: latest version
> Reporter: Thai Ha
>
> I set
> ${pde.ant.configs}=win32,win32,x86
> and the pom.xml contains the below snippet
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>pde-maven-plugin</artifactId>
> <configuration>
> <eclipseInstall>${pde.eclipseInstall}</eclipseInstall>
> <pdeProductFilename>admin.product</pdeProductFilename>
> <pdeBuildVersion>${pde.pdeBuildVersion}</pdeBuildVersion>
> <buildProperties>
> <product>${pde.ant.product}</product>
> <archivePrefix>${pde.ant.archivePrefix}</archivePrefix>
> <configs>${pde.ant.configs}</configs>
> <base>${pde.ant.base}</base>
> </buildProperties>
> </configuration>
> But the command "mvn install" creates error
> "\..\..\I.TestBuild\TestBuild-*.*.*.zip does not". After investigating the
> code, I find out that Ant properties which are set by <buildProperties> have
> no effect at some places. For example
> EclipsePDEMojo.java, lines: 215-217
> ----------------------------------------------------------
> String config = convertPdeConfigsToFilenameSuffix(
> buildConfigurationProperties.getString( "configs" ) );
> return new File( getPDEBuildDirectory(),
> buildConfigurationProperties.getString( "buildLabel" ) + "/"
> + buildConfigurationProperties.getProperty( "buildId" ) + "-"
> + config + ".zip" );
> -----------------------------------------------------------
> Clearly that the properties which are loaded from
> buildConfiguration\build.properties always are used (and properties which are
> set by <buildProperties> have no effect) in this code snippet. I believe that
> the properties are set by <buildProperties> must be used if they exist
> because they have higher priority, but the current code ignore these
> properties. As a result, if I want to set configs=win32,win32,x86, I must
> update build.properties because setting it in <buildProperties> has no effect.
> EclipsePDECleanMojo.java and EclipsePDEMojo.java have references to
> buildConfigurationProperties and they should be fixed to allow properties
> inside <buildProperties> have higher priority than build.properties.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
