Here it is the patch for using remote repositories when downloading
gwt-dev-$OS.jar:
Index:
/home/kana/work/eclipse/workspace/maven-gwt-plugin/gwt-maven-plugin/src/main/java/de/saumya/mojo/gwt/AbstractGWTMojo.java
===================================================================
---
/home/kana/work/eclipse/workspace/maven-gwt-plugin/gwt-maven-plugin/src/main/java/de/saumya/mojo/gwt/AbstractGWTMojo.java
(revision
216)
+++
/home/kana/work/eclipse/workspace/maven-gwt-plugin/gwt-maven-plugin/src/main/java/de/saumya/mojo/gwt/AbstractGWTMojo.java
(working
copy)
@@ -63,6 +63,14 @@
private ArtifactFactory artifactFactory;
/**
+ * List of Remote Repositories used by the resolver
+ * @parameter expression="${project.remoteArtifactRepositories}"
+ * @readonly
+ * @required
+ */
+ protected java.util.List remoteRepos;
+
+ /**
* Location of the source files.
*
* @parameter expression="${project.build.sourceDirectory}"
@@ -248,9 +256,9 @@
this.artifactFactory.createArtifact( "com.google.gwt",
artifactId, version, Artifact.SCOPE_COMPILE, "jar" );
try
{
- // there are no public remote repositories with GWT jar
files, so use
- // empty list !!
- this.artifactResolver.resolve( artifact,
Collections.EMPTY_LIST, this.localRepository );
+ // There might be no public remote repositories with GWT
jar files,
+ // but the user might have installed them into her own.
+ this.artifactResolver.resolve( artifact,
this.remoteRepos, this.localRepository );
}
catch ( ArtifactResolutionException e )
{
On 4/26/07, Kostis Anagnostopoulos <[EMAIL PROTECTED]> wrote:
On 4/25/07, Joerg Hohwiller <[EMAIL PROTECTED]> wrote:
> Kostis Anagnostopoulos schrieb:
> > Hi Kristian,
> Hi Kostis,
> >
> > I have uploaded the gwt dev jars into my company's remote repo and i would
> > like the gwt plugin to take advantage of them.
> >
> > So i patch the plugin to read them through the repositories (which is more
> > maven-way).
> >
> > Lets hope you make a stable release soon of this plugin.
>
> which gwt-plugin are you talking about?
> https://svn.codehaus.org/mojo/trunk/mojo/mojo-sandbox/gwt-maven-plugin/
> or
> http://jira.codehaus.org/browse/MOJO-549
I'm certainly talking about the http://jira.codehaus.org/browse/MOJO-549!
>
> The one submitted in MOJO-549 is working fine and uses the gwt artifacts
> from the repository. You will need to supply the desired GWT version
> via -Dgwt.version=1.3.3 to your maven build or better as configuration
> to the gwt-plugin in your build section.
>
Are you sure that is indeed downloads the
gwt-dev-{linux,max,windows}.jar from the remote repositories?
At least in my installation, it download just the gwt-user.jar and
gwt-servlet.jar
Unfortunately, the patch didn't make it through the mailing list, but
i sent it CC to Kristian.
If you could take a quick look at my patch you would see that the
original code explicitly resolved the gwt-dev-linux.jar artifact
*without* using any remote repositories:
instead of providing a list of remote repositories into
artifactResolver.resolve(), it provided an empty list!
Tomorrow, i will also send you the patch.
For the rest of your comments, I'm awaiting to make a stronger case in
support of your suggestions later.
In the mean time - and in your spare time - you can read this
(http://kerneltrap.org/node/8059)
to get the notion of personal-pride, competition and gatekeeping as
they apply to free software development.
Regards,
Kostis
> > Regards,
> > Kostis
> Regards
> Jörg
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
