Do not relocate and other fixes
-------------------------------

                 Key: MOJO-773
                 URL: http://jira.codehaus.org/browse/MOJO-773
             Project: Mojo
          Issue Type: Bug
          Components: minijar
            Reporter: Henri Tremblay
         Attachments: patch.txt

Since the RuntimeWrapper wasn't working (see MOJO-767), I tried to workaround. 
So I've added a relocateDependencies property. It might be a duplicate with 
include/excludeDependenciesInRelocation but since these two are not currenctly 
used, I can't guess.

Anyway, this property sets the relocate flag to false to every jar if set to 
false itself. From there, I had to modify JarUtils from vafer because JarUtils 
was using the wrapper even when the jar isn't relocated. This seems useless. So 
now it doesn't wrap anything when the jar isn't relocated.

>From there, I've fix some other bugs:

# replaceArtifact wasn't working. You need to delete the original artifact 
first (the renameTo method was returning false)
# When not relocating, closeQuietly and onStopJar weren't ever called
# I'm taking the manifest of the project artifact to put in the ueber jar. I 
think it's better than no manifest at all.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to