[EMAIL PROTECTED] wrote:
Revision
4023 <http://fisheye.codehaus.org/changelog/mojo/?cs=4023>
Author
kaare
Date
2007-05-03 08:59:23 -0500 (Thu, 03 May 2007)
Log Message
do not halt on error setting sysprop, but logs it to sys.err if debug is set
Modified Paths
*
trunk/mojo/appassembler/appassembler-booter/src/main/java/org/codehaus/mojo/appassembler/booter/AppassemblerBooter.java
<#trunkmojoappassemblerappassemblerbootersrcmainjavaorgcodehausmojoappassemblerbooterAppassemblerBooterjava>
Diff
Modified:
trunk/mojo/appassembler/appassembler-booter/src/main/java/org/codehaus/mojo/appassembler/booter/AppassemblerBooter.java
(4022 => 4023)
---
trunk/mojo/appassembler/appassembler-booter/src/main/java/org/codehaus/mojo/appassembler/booter/AppassemblerBooter.java
2007-05-03 13:38:03 UTC (rev 4022)
+++
trunk/mojo/appassembler/appassembler-booter/src/main/java/org/codehaus/mojo/appassembler/booter/AppassemblerBooter.java
2007-05-03 13:59:23 UTC (rev 4023)
@@ -128,16 +128,24 @@
while ( iter.hasNext() )
{
String line = (String) iter.next();
- String[] strings = line.split( "=" );
- String key = strings[0];
- String value = strings[1];
-
- if ( debug )
Dude, catching Throwables is not the right way. What kind of exceptions
dud yo get here? There are only two possibilities that I can see:
+ try
{
- System.err.println( "Setting system property '" + key + "' to '" + value
+ "'." );
+ String[] strings = line.split( "=" );
+ String key = strings[0];
+ String value = strings[1];
There you can get an ArrayIndexOutOfBoundsException when referencing
string[1].
+ if ( debug )
+ {
+ System.err.println( "Setting system property '" + key + "' to '" +
value + "'." );
+ }
+
+ System.setProperty( key, value );
If value is null you'll get an NullPointerException.
+ } catch (Throwable e) {
+ if ( debug )
+ {
+ System.err.println( "Error Setting system property with value '" +
line + "'." );
+ }
}
If you add checks for those possible errors there should be no need to
catch Throwable.
--
Trygve
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
