Ok, investigated more and realised the source roots aren't used
anywhere else, so are a poor basis for canGenerate(). I've changed it
to check for the existence of target/classes which should only happen
if the project contains something to compare against. It could
possibly be made better by actually checking for classes in the
classfilter created in executeClirr instead.
Anyway, +1 to release from SVN rev#4280
Cheers,
Brett
On 04/06/2007, at 1:29 PM, Brett Porter wrote:
The fix for MCLIRR-2 is not really correct. This makes the @execute
phase irrelevant, and it causes clirr:clirr to fail on something
like maven-model where the sources are generated.
I think the problem is that executedProject doesn't appear to be
working under Maven 2.0.6 for reports in the site.
What I've done is reverted back to executedProject, but added the
normal project source directories before the check.
Cheers,
Brett
On 03/06/2007, at 5:14 AM, Jochen Wiedmann wrote:
Hi,
I'd like to cut a new release of the clirr-maven-plugin. Compared to
version 2.0, the following changes have been made:
- Added the "comparisonArtifacts" parameter, which allows to use
select arbitrary
artifacts for comparison.
- Snapshot builds are now ignored when selecting the predecessor.
Fixes MOJO-723.
Thanks to Roland Asmann.
- An exception was thrown, if no previous version was found. This
made it impossible
to configure the plugin in parent projects. An error message is
now logged instead.
Fixes MOJO-723. Thanks to Roland Asmann.
- The wrong project was used, when checking, whether the project
has sources.
Fixes MCLIRR-2. Thanks to Vincent Massol.
- A condition was inverted when checking, whether the user provided
an artifact for
comparison. Fixes MCLIRR-5. Thanks to Mathias Brökelmann.
A current snapshot has been deployed at
http://snapshots.repository.codehaus.org/org/codehaus/mojo/
clirr-maven-plugin/2.1-SNAPSHOT/
The proposed site is available at
http://mojo.codehaus.org/clirr-maven-plugin
Thanks,
Jochen
--
Women have the ability to wind you round their little finger.
Daughters can use all of the fingers together.
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
