[ 
http://jira.codehaus.org/browse/MOJO-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103292
 ] 

Igor Grapp edited comment on MOJO-857 at 7/25/07 9:59 AM:
----------------------------------------------------------

Added 2 patch files from trunk.

I have 2 notes though:

1. I would combine "extraArguments" and "systemProperties" fields in 
jvmSettings model into a single field - it is being placed together   on jvm 
command line anyway.
2. Not sure if  "library" element need to be added into jvmSettings  model  - I 
just used custom "wrapper.conf.template"  with proper libraries added. 


 was:
Added 2 patch files with from trunk.

I have 2 notes though:

1. I would combine "extraArguments" and "systemProperties" fields in 
jvmSettings model into a single field - it is being placed together   on jvm 
command line anyway.
2. Not sure if  "library" element need to be added into jvmSettings  model  - I 
just used custom "wrapper.conf.template"  with proper libraries added. 

> Various adjustements to  appassembler:generate-demons goal
> ----------------------------------------------------------
>
>                 Key: MOJO-857
>                 URL: http://jira.codehaus.org/browse/MOJO-857
>             Project: Mojo
>          Issue Type: Improvement
>          Components: appassembler
>            Reporter: Igor Grapp
>         Attachments: appassembler-maven-plugin-trunk.diff, 
> appassembler-model-trunk.diff, appasssembler-maven-plugin.diff, 
> appasssembler-model.diff
>
>
> I have adjusted appassembler-maven-plugin source to adapt it for our 
> development team and would like to contribute my updates into main source 
> branch.
> Updates include following items:
> 1. Fixed  bugs in JavaServiceWrapperDaemonGenerator to properly  initialize 
> JvmSettings and nt-service parameters in  wrapper.conf
>  
> 2. Added  JavaArguments parameters  ( needed  -Dlog4j.config=... for my 
> project )
> 3. Ability to customize wrapper.conf file by adding   wrapperConfFile  
> parameter to "<daemon>", specifying custom wrapper.conf.template. ( needed to 
> adjust "java.library.path" and "debug" settings )
> 4. Added "repoPath" parameter  ( same as in  assemble goal )
> 5. Added "includeConfigurationDirectoryInClasspath" ( same as in assemble 
> goal )

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to