[ 
http://jira.codehaus.org/browse/MOJO-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104727
 ] 

Stephen Connolly commented on MOJO-885:
---------------------------------------

Looking at the code, there is an assumption in XDocsReporter.addBugReport that 
the bugInstance is for the current class.

It may be that findbugs is not obeying this assumption

OR

It may be that the observer contract used in the constructor is not following 
this assumption.

Perhaps some probe code could be added.... I'll give a quick check to see what 
I can do.

> findbugs xdoc format associates some bug instances with the last file 
> processed
> -------------------------------------------------------------------------------
>
>                 Key: MOJO-885
>                 URL: http://jira.codehaus.org/browse/MOJO-885
>             Project: Mojo
>          Issue Type: Bug
>          Components: findbugs
>            Reporter: Stephen Connolly
>            Assignee: Garvin LeClaire
>            Priority: Minor
>
> When using the xdoc format, some of the bug instances do not get associated 
> with the correct files.  Any that don't get associated get associated with 
> the last file processed by findbugs.
> Initially I though it was just picking files at random, but since clearing 
> the findbugs from the last file (in alphabetical order) I am still seeing 
> findbugs reported against bugs in other classes.
> e,g,
> The classnames and package names have been changed to protect the innocent!
> I have not been able to get a good small testcase that is free from my 
> employers copyright code.
> -Stephen.
> <BugCollection version="1.2.0" threshold="Normal" effort="Default">
>   <file classname="com.foo.foo.FooBar$1">
>     <BugInstance type="UWF_NULL_FIELD" priority="Normal" 
> category="CORRECTNESS" message="UwF: Field only ever set to null: 
> com.bar.bar.Bar.bar" lineNumber="28"/>
>     <BugInstance type="UWF_NULL_FIELD" priority="Normal" 
> category="CORRECTNESS" message="UwF: Field only ever set to null: 
> com.bar.bar.Bar.foo" lineNumber="29"/>
>     <BugInstance type="UWF_NULL_FIELD" priority="Normal" 
> category="CORRECTNESS" message="UwF: Field only ever set to null: 
> com.bar.bar.Foo.bar" lineNumber="28"/>
>     <BugInstance type="UWF_NULL_FIELD" priority="Normal" 
> category="CORRECTNESS" message="UwF: Field only ever set to null: 
> com.bar.bar.Foo.foo" lineNumber="29"/>
>     <BugInstance type="MS_PKGPROTECT" priority="Normal" 
> category="MALICIOUS_CODE" message="MS: 
> com.bar.foo.TomcatApacheDetails.TOMCAT_SERVICE_NAMES should be package 
> protected" lineNumber="15"/>
>   </file>
> <Errors>
> </Errors>
> </BugCollection>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to