[
http://jira.codehaus.org/browse/MWEBSTART-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_106399
]
Kevin Stembridge commented on MWEBSTART-47:
-------------------------------------------
Can you elaborate on your question. I don't quite understand what you mean.
When you say 'to reuse your generator', do you mean modify the existing
Generator to extend the new AbstractGenerator in the patch?
By 'this merging', do you mean 'applying this patch'?
If you agree with the approach of creating a common superclass for the
Generator and JarResourcesGenerator then you can either apply the patch as it
is and then I fix Generator, or I fix Generator and provide a new patch. Your
call, just let me know :)
> Generator and JarResourcesGenerator should have common superclass.
> ------------------------------------------------------------------
>
> Key: MWEBSTART-47
> URL: http://jira.codehaus.org/browse/MWEBSTART-47
> Project: Maven 2.x Webstart Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-2
> Reporter: Kevin Stembridge
> Priority: Minor
> Attachments: MWEBSTART-47-1.diff
>
>
> A new class, JarResourcesGenerator, was created as part of the work done for
> MWEBSTART-38. It was created by copying the existing Generator class and
> modifying it for JarResources. These classes should have a common superclass
> so that they can both make use of new features such as the introduction of an
> explicitTimestamp placeholder. See MWEBSTART-40.
> Jerome, I'll get a patch under way. Let me know if there is anything in
> particular you'd like me to watch out for.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
